Jiseoup/showmycodePublic
EN|KO
  • Code
  • Commits
  • Pull Requests
← Back to list

fix: validate PR number param and use i18n for repo visibility badge

JiseoupJiseoup · Jun 13, 202677211a7

Files changed2+3 -1

Changed files

+3 -1 · 2

@@ -1,3 +1,4 @@
+import { notFound } from "next/navigation";
import Link from "next/link";
import Image from "next/image";
import { getPull, getPullFiles, getPullCommits } from "@/lib/github";
@@ -45,6 +46,7 @@ export default async function PullDetailPage({ params, searchParams }: Props) {
const { lang, owner, repo, number } = await params;
const { tab: tabParam } = await searchParams;
const prNumber = parseInt(number, 10);
+ if (isNaN(prNumber)) notFound();
const tab: Tab = tabParam === "commits" ? "commits" : tabParam === "files" ? "files" : "overview";
@@ -88,7 +88,7 @@ export function RepoCard({
{/* Private/Public badge. */}
<span className="border-border text-muted-foreground shrink-0 rounded-full border px-2 py-0.5 text-xs">
- {repo.private ? "Private" : "Public"}
+ {repo.private ? dict.private : dict.public}
</span>
</div>
</Link>